Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Hi!
This is my first time creating a pull request for home assistant. I am not sure how to run local tests for the supervisor app, but if that is something that is required for me to do I would be glad to do so! I might need some help in that area though.

If there is anything else I can help with or questions I can answer please feel free to let me know!

Thanks!

I added the FolderMapping dataclass and made the corresponding changes. I tried for the last couple of hours to get a local supervisor running against the main branch with no success. Here is the error message in case it is helpful:

ERROR: failed to solve: process "/bin/ash -o pipefail -c set -x && apk add --no-cache coreutils eudev eudev-libs git libffi libpulse musl openssl yaml && curl -Lso /usr/bin/cosign \"https://github.com/home-assistant/cosign/releases/download/${COSIGN_VERSION}/cosign_${BUILD_ARCH}\" && chmod a+x /usr/bin/cosign" did not complete successfully: exit code: 6

Anyway, the reason I say that is because there may be issues that I'm not able to test so if you encounter any issues with my changes please let me know and I will do my best to resolve them.

Thanks!

I added the FolderMapping dataclass and made the corresponding changes. I tried for the last couple of hours to get a local supervisor running against the main branch with no success. Here is the error message in case it is helpful:

ERROR: failed to solve: process "/bin/ash -o pipefail -c set -x && apk add --no-cache coreutils eudev eudev-libs git libffi libpulse musl openssl yaml && curl -Lso /usr/bin/cosign \"https://github.com/home-assistant/cosign/releases/download/${COSIGN_VERSION}/cosign_${BUILD_ARCH}\" && chmod a+x /usr/bin/cosign" did not complete successfully: exit code: 6

Anyway, the reason I say that is because there may be issues that I'm not able to test so if you encounter any issues with my changes please let me know and I will do my best to resolve them.

Thanks!

You need a new version of devcontainer -> https://github.com/home-assistant/devcontainer

Oh shoot. @pvizeli we can't put this in addons/data.py as that is already taken by something entirely different. The class for managing config data of an addon is in there and so yea we now get a circular import issue trying to use it for common dataclasses.

How about addons/configuration.py like we do in resolution instead?

Oh shoot. @pvizeli we can't put this in addons/data.py as that is already taken by something entirely different. The class for managing config data of an addon is in there and so yea we now get a circular import issue trying to use it for common dataclasses.

How about addons/configuration.py like we do in resolution instead?

@mdegat01 I moved the FolderMapping dataclass to configuration.py as you suggested. If there are any other changes I should make just let me know!

@jgoakley it looks like there's conflicts with the base branch. Can you rebase and resolve that? Then this is good to get merged.

@jgoakley it looks like there's conflicts with the base branch. Can you rebase and resolve that? Then this is good to get merged.

Hi @mdegat01, I think I accidently did a merge commit instead of a rebase when clicked "update branch" in GitHub. Sorry about that, I'm not very familiar with rebasing. I also synced my fork and performed a merge in VS Code but I didn't see any conflicts. Is "main" the correct base branch I should be merging into?

@jgoakley all good on the merge vs. rebase. We prefer rebases since it makes the PR easier to review as the only commits are your changes, not the merges. But we squash and merge in the end so it doesn't matter after its merged.

Thanks for the contribution 👍